More consistent defaults for a Swarm service
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
In official Docker documentation regarding Swarm service (https://docs.docker.com/engine/reference/commandline/service_create/) some options have different defaults, than this library.
For example when creating service through Docker CLI (docker service create), option --update-failure-action has default action pause rather than continue as defined in UpdateConfig.failure_action here: https://github.com/docker/docker-py/blob/8fea5738d32cfb712fcb05f541bc63eaf1d7ed71/docker/types/services.py#L367
Same thing applies for option --update-parallelism, which has default 1, but in docker-py library UpdateConfig.parallelism has default value 0 (update all at once).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with docker/types/services.py, especially UpdateConfig.failure_action and UpdateConfig.parallelism, and compare their defaults with the Docker service create documentation linked in the issue. Confirm the documented Swarm defaults and update the library so the corresponding values match; check for related tests or callers before considering the change complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100