docker / docker/docker-py

stream logs with container.run

Open
#2,510 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

https://github.com/docker/docker-py/blob/a9867c99126626aa97d94d31f0c2eca3bead4e8f/docker/models/containers.py#L818

Shouldn't this out be yield at this point if stream=True ? otherwise the next step (.wait()) will make caller wait for full execution to get any logs...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at docker/models/containers.py around line 818 and inspect how container.run handles out when stream=True before calling wait(). Reproduce the behavior with a streaming container run and verify that log output becomes available before execution completes; done means callers receive logs incrementally rather than waiting for the full run.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
api, devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.