container get image attribute exception
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
python-docker: 4.0.2, 4.1.0
docker engine API: 1.93
If create the container with the image that isn't in local(eg: pull from remote), and interrupted during creation. May leave some containers without image information.
And get an error when getting the image attribute of these containers.
#...
return self.client.images.get(image_id.split(':')[1])
IndexError: list index out of range
Maybe it can be fixed like this.
@property
def image(self):
"""
The image of the container.
"""
image_id = self.attrs.get('ImageID', self.attrs['Image'])
# if image_id is None or image_id is '':
if not image_id:
return None
return self.client.images.get(image_id.split(':')[1])
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in docker/models/containers.py around the Container.image property at the linked lines, and reproduce or inspect the case where an interrupted remote-image creation leaves no image information. Done means accessing the image attribute no longer raises IndexError when the container has no image information.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100