updating docker service with empty resources object does not delete resources
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
looks like if you update an existing service with resources (i.e. cpu limits, reservations) with a blank resource (None, {} or docker.types.Resource()), it does not delete existing resources. The update just reports true and the service still has the resources if you look at the docker attributes. (['Spec']['TaskTemplate']['Resources'])
I'm using docker 3.4.1.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce an update of an existing Docker service using None, {}, or docker.types.Resource() after resources have been configured. Inspect the resulting service attributes at Spec.TaskTemplate.Resources; done means the empty update removes the existing CPU limits and reservations instead of reporting success while retaining them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100