docker / docker/docker-py

Integrate dockerpty into this package

Open
#2,090 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

The dockerpty package was pretty helpful, but appears to have been abandoned two years ago, and hasn't been kept up-to-date with this package.

Would it be acceptable to produce a PR against this repo that attempts to merge that code into this upstream? It'd be great to have the support of the original authors, but it is licensed as Apache 2.0, and therefore compatible with the license from this project as long as the original copyright notice is include (I believe?).

Thoughts? I'd be happy to help produce said PR if it would be amenable to this project's maintainers (and I'll reach out to the dockerpty folks to see if they would be willing to support as well, though they seem to have gone dark).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin with the linked dockerpty package and this repository's contribution and licensing guidance. Ask maintainers to define whether merging the abandoned code is wanted and what compatibility scope is required; done would be a reviewed PR that integrates the agreed code while preserving the original copyright notice.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.