docker / docker/docker-py

functional test using the unix socket

Open
#1,803 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Python
Stars
7.2k
Forks
1.7k
Avg merge
13d 8h
Merged PRs (30d)
2

Description

From https://github.com/docker/docker-py/pull/1801#issuecomment-343286272

Unfortunately, our CI only tests the HTTP(s) transport, not the unix socket transport, which is why this wasn't caught in the first place. In the medium term, we definitely need to test on both, as any of our exec_run or attach tests would have highlighted the problem.

not the unix socket transport,

This is probably the most used transport!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing functional tests for exec_run or attach and the CI setup that currently exercises HTTP(s) only. Add coverage for the Unix socket transport alongside the existing transport coverage, and verify that those tests run successfully in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
backend, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.