Error with --email flag deprecation for `docker login`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
In the 17.0.6 docker engine update, the -e and --email flags were deprecated. Sending the -e flag now results in a 400 error. The client should attempt to check the docker version or re-try without the email flag if it fails. This is a breaking change in the docker application, and should be fixed as soon as possible.
https://docs.docker.com/engine/deprecated/#-e-and---email-flags-on-docker-login
Originally encountered this issue with
$(aws ecr get-login)
This calls:
docker login -u AWS -p <TOKEN> -e none <ECR_URL>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing docker login handling for the deprecated -e and --email flags, using the Docker deprecation notice and the aws ecr get-login example as context. Confirm the current Docker Engine behavior and determine how the client should handle a 400 response; done means docker login no longer fails because of the deprecated email flag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- authentication, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100