tag image failed without tag parameter
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 13d 8h
- Merged PRs (30d)
- 2
Description
Check from source code: https://github.com/docker/docker-py/blob/master/docker/api/image.py#L261
Parameter tag with default value None. But didn't handle it when tag is None.
It will raise docker.errors.APIError: 500 Server Error: Internal Server Error ("invalid reference format") exception.
I think there two ways to fix this:
- same as docker cli. Append
latesttag if it is None. - check parameter
repositorywith tag or not. If yes, just using the tag fromrepository
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at docker/api/image.py around line 261 and reproduce tagging an image with tag=None. Compare the behavior with the Docker CLI and inspect how a repository tag is represented. Done means the API no longer sends an invalid image reference when no explicit tag is provided, with the intended handling documented or covered by the relevant existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100