docker / docker/docker-install
lsb_release command existence checking in check_forked()
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 3.2k
- Forks
- 863
- Avg merge
- 3h 15m
- Merged PRs (30d)
- 2
Description
lsb_release does not have an option '-u' so this check will always result as false.
It could just check for the '-a' option.
The issue with this, is that the else statement checks the '-r' option so the script will likely to fail in all Debian based distros.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with install.sh around lines 308 and 328, then inspect how check_forked() invokes lsb_release and selects the Debian-based branch. Verify the available lsb_release options and exercise the script on a Debian-based distribution. Done means the existence check succeeds and the intended branch no longer fails because of the option check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100