docker / docker/docker-ce-packaging

CI should validate expected files are included somehow

Open
#925 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
209
Forks
164
Avg merge
2h 24m
Merged PRs (30d)
4

Description

Related to the typos caught in https://github.com/docker/docker-ce-packaging/pull/914 (that were in my original PR! 😂 🤦), it would probably be a good idea to add to the CI here some kind of validation that the end result includes some fixed set of expected files (such as docker.socket, docker.service, etc), if not outright somehow verifying that they work correctly (maybe installing them in the GHA "host" environment?).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing GitHub Actions packaging workflow and inspecting the generated package contents. Add validation for required files such as docker.socket and docker.service, with CI failing when they are absent; the issue is done when the check runs reliably for the supported packages.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, github-actions
Domain
build-system, ci-cd, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.