docker system prune warn message should display filters if any
Open
Nobody has claimed this yet.
kind/enhancement
- Dominant language
- Go
- Stars
- 6.1k
- Forks
- 2.2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
Description
When running a system prune with filter, the warning message doesn't reflect that the filter will be used.
We should display that the elements pruned will be filtered.
Describe the results you received:
$ docker system prune --filter=label=foo Tue 30 Jan 2018 03:16:42 PM PST
WARNING! This will remove:
- all stopped containers
- all networks not used by at least one container
- all dangling images
- all build cache
# […]
Describe the results you expected:
Same message but that acknowledge the filtering.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the docker system prune command path and reproduce the warning using --filter=label=foo. Compare the warning with and without a filter; done when the message acknowledges the filtered scope while preserving the existing prune behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100