docker / docker/cli

Docker CLI should use mount API for --tmpfs

Open
#710 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

This is a follow-up to https://github.com/moby/moby/pull/35467#issuecomment-345036525

The --tmpfs option adds tmpfs mounts to a container. This option is currently handled daemon-side, where mounts specified through --tmpfs are merged with the default mounts, mounts from -v / --volume, and mounts specified through --mount.

We should change the CLI to use the Mount API

Question

  • Should we do the same for --shm-size?
  • If we do; where are the defaults set? i.e., we likely don't want the CLI to be aware of any defaults set by the daemon for /dev/shm; how can we provide a custom --shm-size, but keep other defaults as-is?

ping @kolyshkin @cpuguy83 @AkihiroSuda PTAL

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Docker CLI handling for --tmpfs, the Mount API version-history entry for API 1.25, and the referenced pull requests. Define how --tmpfs maps to --mount type=tmpfs while preserving the fallback for older daemons; resolve whether --shm-size belongs in the same change and how daemon defaults remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.