Support BROWSER env variable when selecting a browser to launch for oauth2
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.1k
- Forks
- 2.2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
Description
The current code for launching a browser to do oauth2 login in Linux hardcodes three linux browser launchers.
providers := []string{"xdg-open", "x-www-browser", "www-browser"}
vendor/github.com/pkg/browser/browser_linux.go
It would be nice if that choice could be overridden via the standard BROWSER= env variable. This would allow the end user to provide alternative browser launch commands. This is, for example, what the github browser utility does go-gh/blob/trunk/pkg/browser/browser.go
The use case for this is users running in dev containers. This allows them to have custom scripts that forward the browser request to outside of the dev container so it can be launched from the host browser (since the dev container likely does not contain a gui browser)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vendor/github.com/pkg/browser/browser_linux.go and compare its Linux launcher selection with the referenced go-gh browser implementation. Done when the standard BROWSER environment variable can provide the OAuth2 browser launch command while the existing Linux launcher behavior remains available when it is unset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication, cli
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100