docker / docker/cli

Use native golang ssh when creating SSH docker client

Open
#6,572 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/feature status/0-triage
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

Description

Presently, if configuring a docker client (in golang), docker is using the system ssh binary by executing a crafted command. This happens in connhelper.go https://github.com/docker/cli/blob/master/cli/connhelper/connhelper.go#L51-L65

Golang offers a robust native ssh client directly in the standard library, and works without needing an installation of an OpenSSH client. For security reasons, we prefer to use this ssh client because we can more easily guarantee it will use FIPS validated algorithms without needing to ensure OpenSSH is setup for FIPS correctly.

Golang makes it extremely easy to use FIPS algorithms, especially as of v1.24 where you no longer need to deal with boringcrypto, so moving this to std lib would drastically decrease complexity of Docker setups where we need FIPS SSH and we're using the Docker SDK inside of golang.

If this is not currently possible, would a feature request like this be accepted?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in cli/connhelper/connhelper.go at lines 51-65 to understand how the Docker SSH client currently invokes the system ssh binary. Review the linked Go SSH and FIPS documentation, then determine whether native SSH support can replace that invocation while meeting the stated FIPS requirements.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.