docker / docker/cli

flaky test: TestPromptExitCode/plugin_upgrade, estPromptExitCode/install

Open
#6,248 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/testing kind/bug
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

Description

This test was recently rewritten from testing plugin upgrade with
DCT enabled to just "plugin upgrade", but there's a fair amount of
complexity in the e2e tests that set up different daemons and registries.

It's possible that tests are affecting each-other, and some state (config)
is left behind.

Let's skip the test for now, and add a tracking ticket to dig deeper.

=== FAIL: e2e/global TestPromptExitCode/plugin_upgrade (7.55s)
    cli_test.go:205: assertion failed: 
        Command:  docker plugin push registry:5000/plugin-upgrade-test:latest
        ExitCode: 1
        Error:    exit status 1
        Stdout:   The push refers to repository [registry:5000/plugin-upgrade-test]
        459089aa5943: Preparing
        adc41078d1d9: Preparing
        d7bff979db13: Preparing
        459089aa5943: Preparing
        
        Stderr:   error pushing plugin: failed to do request: Head "https://registry:5000/v2/plugin-upgrade-test/blobs/sha256:adc41078d1d937495df2f90444e5414a01db31e5a080f8aa4f163c64d41abd11": http: server gave HTTP response to HTTPS client
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in cli_test.go around line 205 and locate TestPromptExitCode/plugin_upgrade, then review the related estPromptExitCode/install test and the surrounding e2e setup. Confirm the failure is caused by shared daemon, registry, or configuration state; done for this issue means the flaky test is skipped and a tracking ticket records the investigation needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli, testing-qa
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.