Remove hardcoded `docker` CLI command name for SSH hosts
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.1k
- Forks
- 2.2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
Description
Currently, when connecting to a remote SSH host, the docker binary name is hard-coded.. This means that if the remote host doesn't have a binary named docker in the path, remote SSH support doesn't work.
There are two specific use-cases this makes difficult:
- Systems where
dockerisn't in the path for the SSH connection, and - Systems where the
dockerbinary has another name.
If this hard-coded default could be overridden, these use-cases could be supported.
Proposal
Introduce the DOCKER_SSH_REMOTE_BINARY environment variable, which will be used in place of the bare docker binary if set. I'll raise a PR for this change then link to it.
Associated PR: https://github.com/docker/cli/pull/5627
Related
Would resolve https://github.com/docker/cli/issues/3045
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The affected entry point is cli/connhelper/connhelper.go around line 52; start there and inspect the existing SSH command construction. Done means the DOCKER_SSH_REMOTE_BINARY override is honored while the current docker default remains, with behavior checked against associated PR #5627.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100