docker / docker/cli

Flaky test: TestPluginSocketBackwardsCompatible

Open
#5,617 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/plugins area/testing kind/bug
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

Description

Test has failed on various PRs;

 === FAIL: e2e/cli-plugins TestPluginSocketBackwardsCompatible/detached/the_main_CLI_exits_after_3_signals (1.11s)
    socket_test.go:111: docker --config /tmp/plugin-test-1548696475 presocket test-no-socket
    socket_test.go:139: assertion failed: 255 (int) != 1 (int)
    socket_test.go:140: assertion failed: expected error to contain "exit status 1", got "exit status 255"
    socket_test.go:145: assertion failed: 
        --- ←
        +++ →
        @@ -1,2 +1,2 @@
        -exit status -1
        +got 3 SIGTERM/SIGINTs, forcefully exiting
         
=== Failed
=== FAIL: e2e/cli-plugins TestPluginSocketBackwardsCompatible/detached/the_main_CLI_exits_after_3_signals (1.11s)
    socket_test.go:110: docker --config /tmp/plugin-test-2009379327 presocket test-no-socket
    socket_test.go:134: assertion failed: expected error to contain "exit status 1", got "exit status 255"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with e2e/cli-plugins/socket_test.go, especially TestPluginSocketBackwardsCompatible and the detached case shown in the failure. Reproduce the failure with that test, then determine why the expected exit status and signal message vary; done means the test is reliable and its assertions match the intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.