docker / docker/cli

The `socket` package should hanndle reconnects and possibly mutliple connections

Open
#4,899 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/feature status/0-triage
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

Description

The CLI socket package allows for plugins to connect to the CLI. The CLI uses this connection to signal to the plugin when to exit, based on OS termination signals. The current implementation does not allows for the plugin to reconnect to the CLI and the CLI has no way of handling multiple connections.

In the future we might want to allow for such situations. For example, the plugin might drop a connection and redial or a plugin might spawn another or the CLI might spawn multiple.

For context, please see this PR https://github.com/docker/cli/pull/4878

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the CLI socket package and the referenced PR #4878 to understand the current connection lifecycle. Define the expected behavior for reconnecting plugins and multiple simultaneous connections; the work is complete when both cases are supported and covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.