plugins: fix "dial-stdio" feature or remove the feature
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.1k
- Forks
- 2.2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
Description
(I noticed this while reviewing https://github.com/docker/cli/pull/4599)
- relates to https://github.com/docker/cli/pull/1745
- relates to https://github.com/docker/cli/pull/1654
- relates to https://github.com/docker/cli/pull/1718
Relates to (https://github.com/docker/cli/issues/1661):
- plugins should call back to main cli using dial-stdio to connect to engine. From CLI Plugins Design https://github.com/docker/cli/issues/1534#issuecomment-446206041 → See PR https://github.com/docker/cli/pull/1654.
Commit https://github.com/docker/cli/commit/ff2ed6efa82ca459a5971e1a8b583df7b892bcdb (https://github.com/docker/cli/pull/1745) disabled dial-stdio for plugins, adding an (undocumnented) DOCKER_CLI_PLUGIN_USE_DIAL_STDIO environment-variable to re-enable the feature. This feature was added in https://github.com/docker/cli/pull/1654, but caused CI failures and didn't work as anticipated.
We should either debug (and fix) the feature, or consider removing it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PRs 1654, 1718, 1745, and the related issue 1661, then inspect the dial-stdio behavior controlled by DOCKER_CLI_PLUGIN_USE_DIAL_STDIO. Done means either the feature works as intended without the reported CI failures or the feature and its enablement path are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100