docker / docker/cli

evaluate signals to handle for exiting plugins (unix / windows)

Open
#4,693 0 comments 0 reactions 1 assignee View on GitHub

@laurazard is already working on this.

Since Dec 4, 2023.

area/plugins kind/refactor
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

I realise this was taken from the original appcontext package; mostly curious if this is the only signal that can/should be handled on Windows.

I also know we maintain the moby/sys/signal module with some generalisation of signals, but no idea if that is any useful here; https://github.com/moby/sys/blob/main/signal/signal_windows.go

Originally posted by @thaJeztah in https://github.com/docker/cli/pull/4599#discussion_r1400310668

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.