docker / docker/cli

Feature request: Docker search cli doesn't adhere to docker [object] [verb] style

Open
#1,676 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/distribution area/ux
Dominant language
Go
Stars
6.1k
Forks
2.2k
Avg merge
1d 15h
Merged PRs (30d)
43

Description

Description

The "new" docker cli commands all adhere to the docker [object] [verb] command. So we new prefer docker container run over docker run, docker image rm over docker rmi etc.

However, docker search still uses the old docker [verb] command, and it seems there's no modern variant available.

As all other commands that interact with a registry (be it private or the hub) are verbs on the image object, I would have expected docker image search to work. Yet it doesn't. Is there a particular reason for this?

Output of docker version:

frank@box:~$ docker version
Client:
 Version:           18.06.1-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        e68fc7a
 Built:             Tue Aug 21 17:24:58 2018
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.1-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       e68fc7a
  Built:            Tue Aug 21 17:23:24 2018
  OS/Arch:          linux/amd64
  Experimental:     false

(but happens in 18.09.2 as well)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Docker CLI command registration for docker search and the existing object/verb commands such as docker image rm. Determine whether docker image search should be supported and how its behavior should match docker search, then verify the resulting command through the CLI's relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.