docker / docker/buildx

Improve error reporting and handling for missing build-secrets

Open
#3,285 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
4.5k
Forks
682
Avg merge
2d 14h
Merged PRs (30d)
29

Description

Description

I noticed this while writing up https://github.com/docker/buildx/issues/1193#issuecomment-3027472588

Using this Dockerfile;

# syntax=docker/dockerfile:1

FROM alpine
RUN --mount=type=secret,id=SECRET_TOKEN,env=SECRET_TOKEN printenv SECRET_TOKEN

When building without the SECRET_TOKEN env-var set, an error is produced for a missing file;

docker build --no-cache --progress=plain --secret id=SECRET_TOKEN .
ERROR: failed to build: failed to stat SECRET_TOKEN: stat SECRET_TOKEN: no such file or directory

Exporting the env-var makes the problem go away;

SECRET_TOKEN=super-secret docker build --no-cache --progress=plain --secret id=SECRET_TOKEN .
#0 building with "desktop-linux" instance using docker driver
# ...
#10 DONE 0.9s

When explicitly specitying env as input for the secret, no error is produced in either case, and the build continues even though the env-var is not present;

docker build --no-cache --progress=plain --secret id=SECRET_TOKEN,env=SECRET_TOKEN .
#0 building with "desktop-linux" instance using docker driver
# ...
#10 DONE 0.9s

What I expected to see

For the first case, I'd expected the error message to include some information about the sources that were tried;

  • env-var with the given ID (SECRET_TOKEN)
  • file with the given ID as name (./SECRET_TOKEN)

For the second case, I'd expected the build to fail because the command-line argument explicitly set env as source for the secret;

  • Produce an error if the env-var is not set
  • It's OK to continue if the env-var is set, but empty (which may be a valid use-case).
Info

Reproduced on Docker Desktop with Docker v29.3.0 with containerd image-store enabled;

docker builder inspect
Name:          desktop-linux
Driver:        docker
Last Activity: 2025-07-02 11:29:21 +0000 UTC

Nodes:
Name:             desktop-linux
Endpoint:         desktop-linux
Status:           running
BuildKit version: v0.23.1
Platforms:        linux/arm64, linux/amd64, linux/amd64/v2, linux/riscv64, linux/ppc64le, linux/s390x, linux/386
Labels:
 org.mobyproject.buildkit.worker.containerd.namespace: moby
 org.mobyproject.buildkit.worker.containerd.uuid:      f1b49a59-81d0-436c-a1d4-ebb815a7ecaf
 org.mobyproject.buildkit.worker.executor:             containerd
 org.mobyproject.buildkit.worker.hostname:             docker-desktop
 org.mobyproject.buildkit.worker.moby.host-gateway-ip: 192.168.65.254
 org.mobyproject.buildkit.worker.network:              host
 org.mobyproject.buildkit.worker.selinux.enabled:      false
 org.mobyproject.buildkit.worker.snapshotter:          overlayfs
Devices:
 Name:                  docker.com/gpu=webgpu
 Automatically allowed: false
GC Policy rule#0:
 All:            false
 Filters:        type==source.local,type==exec.cachemount,type==source.git.checkout
 Keep Duration:  48h0m0s
 Max Used Space: 2.764GiB
GC Policy rule#1:
 All:            false
 Keep Duration:  1440h0m0s
 Reserved Space: 20GiB
GC Policy rule#2:
 All:            false
 Reserved Space: 20GiB
GC Policy rule#3:
 All:            true
 Reserved Space: 20GiB

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two missing-secret cases with the Dockerfile and docker build commands shown in the issue. Trace how implicit and explicit secret sources are handled, then verify that errors identify tried sources and that an explicitly requested missing environment variable fails while an empty one remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
build-system, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.