Always print error in the end of history logs command
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4.5k
- Forks
- 682
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 29
Description
Sometimes build can fail because of an error that is not directly associated with a build step or before the associated build step ever ran(eg. if the failure happens in cache key computation). That leaves behind state where if you run buildx history inspect you get error information as expected but if you run buildx history logs then there is no obvious build step with failure.
I think we should just print the error information in the end of history logs, the same way as we do for history inspect. It may even make sense to repeat the logs for the failed step because the initial logs for that step may not be at the end of the output.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the buildx history logs and history inspect command entry points and compare how each renders failures. Reproduce a failure outside a build step, such as during cache-key computation, then verify that history logs ends with the error information and, if applicable, the failed-step logs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100