remove ContextPathHash from driver definition
Open
@AkihiroSuda is already working on this.
Since Mar 6, 2020.
help wanted
- Dominant language
- Go
- Stars
- 4.5k
- Forks
- 682
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 29
Description
Noticed we have https://github.com/docker/buildx/blob/master/driver/manager.go#L87 as part of driver generic properties (added with k8s driver). But this key does not seem to be driver-specific but more defines the build behavior.
I think it should be refactored so that build gets the Driver instance and then type checks against a SetStickyKey() interface that k8s driver can implement and calls it with the context path.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.