dmtrKovalenko / dmtrKovalenko/date-io

Hijri isSameMonth incorrect

Open
#481 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
TypeScript
Stars
754
Forks
92
PR merge metrics
No merged PRs in 30d

Description

`isSameMonth` method returns true even if two dates aren't in the same Hijri month
```js
const date1 = hijri.date("10/06/2020");
const date2 = hijri.addHours(date1, 13 * 24);

date1.format("iYYYY/iM/iD") // 1442/2/19
date2.format("iYYYY/iM/iD") // 1442/3/2
hijri.isSameMonth(date1, date2) // true (it should return false)
```

Here is a link to reproduce the issue: [link](https://codesandbox.io/s/jolly-robinson-dsyi3?file=/src/index.js:111-112)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.