dmlc / dmlc/xgboost

JSON dumps don't have split type

Open
#9,931 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
28.8k
Forks
8.9k
Avg merge
1d 12h
Merged PRs (30d)
54

Description

Function `XGBoosterDumpModel` has an option of dumping to JSON. This JSON output has a field `split_condition` which tells against what to compare the column in field `split`.

The JSON however doesn't mention how this `split_condition` is to be applied - for numeric features, it will be a threshold used as `split < split_condition`, while for categorial features it will use an 'in' condition `split in split_condition`.

The text and 'dot' dump formats both indicate what the split type is.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the XGBoosterDumpModel JSON output path and compare how the text and dot dump formats represent split types. Verify the numeric threshold and categorical “in” cases described in the issue; done means the JSON identifies how split_condition is applied for both feature types.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.