dmlc / dmlc/xgboost

OpenMP detection is still broken on MacOS

Open
#8,946 36 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
28.8k
Forks
8.9k
Avg merge
1d 12h
Merged PRs (30d)
54

Description

Despite an earlier PR claiming to fix it: https://github.com/dmlc/xgboost/pull/8684
It is still broken, at least with GCC:
```
checking whether OpenMP will work in a package... no
*****************************************************************************************
OpenMP is unavailable on this Mac OSX system. Training speed may be suboptimal.
To use all CPU cores for training jobs, you should install OpenMP by running\n
brew install libomp
```
Moreover, it gives a wrong recommendation (`libomp` is Clang-specific).

P. S. IMO it is a bad wording to use “should“ for an optional package manager. One does not need any – `libomp`, while not needed at all with GCC, can be installed directly. Also, there is Macports which has it, not just Homebrew.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.