dmlc / dmlc/xgboost

last interaction constraint example seems wrong

Open
#7,115 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
28.8k
Forks
8.9k
Avg merge
1d 12h
Merged PRs (30d)
54

Description

In https://github.com/dmlc/xgboost/issues/4075#issuecomment-458280942, a very precise definition of feature interaction constraints is given. In my view, the last example in https://xgboost.readthedocs.io/en/latest/tutorials/feature_interaction_constraint.html

![image](https://user-images.githubusercontent.com/16206095/126210442-b9417dec-7ec0-4141-86dc-62dbbe4d6151.png)

is wrong (if the definition is correct).

Why? The ancestor nodes on the right-most branch have feature set {x_0, x_1}. So the last split should also be on either x_0 or x_1.

Am I wrong?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.