dmlc / dmlc/xgboost

[RFC] Memory usage test.

Open
#5,174 0 comments 0 reactions 0 assignees View on GitHub
feature-request
Dominant language
C++
Stars
28.8k
Forks
8.9k
Avg merge
1d 12h
Merged PRs (30d)
54

Description

Currently most of our tests are related to correctness, and some large size benchmarks for performance scattered around developers. But recently I fixed a memory copy bug in https://github.com/dmlc/xgboost/pull/5160 , and a memory leaking bug in #5153 . It becomes obvious that we need some regular memory consumption tests.

One way to do this is using Python's `psutil` module for monitoring virtual memory, another one is using [cgmemtime](https://github.com/gsauthof/cgmemtime) for marking peak memory usage. The second option requires Linux cgroup and root access for setup.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.