[jvm-package] The train DMatrix has been added to eval DMatrix sets twice in spark pipeline.
Open
- Dominant language
- C++
- Stars
- 28.8k
- Forks
- 8.9k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 54
Description
As titled.
The first time to add train DMatrix to eval DMatrix sets is in spark, I mean the `wathces.toMap` already contains train DMatrix here.
https://github.com/dmlc/xgboost/blob/c0fbeff0ab1d266fae89538e405c0ca244576b0c/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala#L331
The second time is in java as below,
https://github.com/dmlc/xgboost/blob/c0fbeff0ab1d266fae89538e405c0ca244576b0c/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/XGBoost.java#L167.
So which one is duplicate ? Or is it by design ?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.