dmlc / dmlc/xgboost

[CMake] Set MSVC_RUNTIME_LIBRARY per target

Open
#11,383 1 comment 0 reactions 1 assignee View on GitHub

@chyunsu3 is already working on this.

Since Apr 2, 2025.

Dominant language
C++
Stars
28.8k
Forks
8.9k
Avg merge
1d 12h
Merged PRs (30d)
54

Description

Setting CMAKE_MSVC_RUNTIME_LIBRARY is not foolproof, as some CMake targets may not have its MSVC_RUNTIME_LIBRARY correctly inherit from CMAKE_MSVC_RUNTIME_LIBRARY. I saw this issue as I was working on https://github.com/dmlc/dmlc-core/pull/693.

It's best to explicitly specify MSVC_RUNTIME_LIBRARY property for all CMake targets.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.