dmlc / dmlc/treelite

Rename `sum_hess` field to `weighted_data_count`

Open
#662 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
830
Forks
112
Avg merge
1d 12h
Merged PRs (30d)
18

Description

When building a treelite model, there is a method `data_count` which takes as input:
```
data_count – Number of data points
```

But if a given tree was fitted to data with sample weights, one would want it to instead represent the sum of weights among the observations, which will not necessarily be integral.

There is a `sum_hess` which takes float, but it's not exactly the same thing.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for `sum_hess` and `data_count` to find their declarations, uses, and any related tests or documentation. Update the field naming consistently so the replacement represents a potentially non-integral sum of sample weights, then run the affected test suite and verify model building still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
machine-learning
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.