dmlc / dmlc/ps-lite

About the lock in ZMQVan::SendMsg

Open
#84 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.6k
Forks
540
PR merge metrics
No merged PRs in 30d

Description

Might the granularity of the lock be smaller? I'm not sure.

I feel that reasons why the lock guards the whole function body are:
1) protect senders_ from racing
2) keep the data transfer to the socket continuously and avoid being interrupted

As for reason 1, smaller granularity is acceptable.
As for reason 2, perhaps other operations than locking could be tried.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.