Make public methods in SimpleApp and KVWorker, KVServer virtual to enable testing.
Open
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 540
- PR merge metrics
- No merged PRs in 30d
Description
I'd like to write tests for components that rely on SimpleApp, KVWorker, and KVServer. The easiest approach to do this is fake or mock SimpleApp, etc., but this is difficult now because the public methods are non-virtual.
Does it seem reasonable to make these virtual?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.