dmlc / dmlc/dlpack

ABI: uint8 too small for potential `complex quad` itemsize bits?

Open
#73 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
1.2k
Forks
169
PR merge metrics
No merged PRs in 30d

Description

If quad-precision takes off, then the current `uint8` for the itemsize cannot represent the `128+128 = 256` bits of a complex quad number. Even now that would fail for most `long double` storage formats (those cannot be represented right now, so I am not sure it matters).

If an ABI break is necessary in the future, maybe this should be bumped to uint16 (maybe some other ones as well)? I guess there will be other ways to work around the limitation, though. And I admit quad-precision complex may well be as bad as it gets and is _just_ at the limit.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.