dmlc / dmlc/dgl

[Doc] Write your own GNN module -- Example Code Improvement

Open
#7,856 1 comment 1 reaction 0 assignees View on GitHub
stale-issue
Dominant language
Python
Stars
14.3k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Description

## 📚 Documentation

Tutorial part: [Write your own GNN module ](https://www.dgl.ai/dgl_docs/tutorials/blitz/3_message_passing.html#write-your-own-gnn-module)

In the [Training Loop code](https://www.dgl.ai/dgl_docs/tutorials/blitz/3_message_passing.html#training-loop), there is a variable `all_logits`, which is present in the code and is accumulating the `logits` at each epoch but this accumulation is not being used anywhere.

I think it is better to remove `all_logits` from the code rather than keeping it as it causes confusion to the new users, it makes them think why are the logits being accumulated, when they are never being used.

If this seems an improvement, I can do a PR with the changes.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.