dmlc / dmlc/dgl

Possible incorrect implementation of teacher forcing in DTGRNN example

Open
#5,802 3 comments 0 reactions 1 assignee Claimed by @sneakerkg View on GitHub
bug:unconfirmed stale-issue
Dominant language
Python
Stars
14.3k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Description

It seems that the teacher forcing scheme during training for [dtgrnn](https://github.com/dmlc/dgl/tree/master/examples/pytorch/dtgrnn) is incorrect. At this [line](https://github.com/dmlc/dgl/blob/master/examples/pytorch/dtgrnn/model.py#L219) in the decoder the teacher state is sent in as input.

```
inputs, hidden_states = self.decoder(
g, teacher_states[i], hidden_states
)
```

This should be the _previous_ timestep's target, not the current timestep's target. This means the decoder is getting the target at every input and so its just learning how to replicate this input instead of predicting the next.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.