dmlc / dmlc/dgl

[Bug] reset_parameters() does not reinitialize the bias items in dgl.nn.SAGEConv

Open
#4,994 1 comment 0 reactions 0 assignees View on GitHub
bug:confirmed
Dominant language
Python
Stars
14.3k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Description

## 🐛 Bug

Method `reset_parameters` in https://github.com/dmlc/dgl/blob/a2defae2bfc79af442156f5177aeb5f2ece91f71/python/dgl/nn/pytorch/conv/sageconv.py#L133-L152 does not reinitialize the bias items of `self.fc_pool.weight`, `self.fc_self.weight` and `self.fc_neigh.weight`.

## To Reproduce

## Expected behavior

Reinitialize all learnable parameters including the bias.

## Environment

- DGL Version (e.g., 1.0): 0.9
- Python version: 3.9

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.