dmlc / dmlc/dgl

[Sparse] Resolve macro conflicts between Pytorch and DGL loggers.

Open
#4,943 4 comments 0 reactions 0 assignees View on GitHub
topic: Sparse API
Dominant language
Python
Stars
14.3k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Description

## 🚀 Feature
The sparse library has macro redefinition problems when including headers from Pytorch and DGL at the same time. Typical macros are `LOG`, `CHECK` and `CHECK_EQ`. The current workaround is to include all DGL headers in one file and undef these macros. We need a more elegant way to resolve the problem.

## Motivation

## Alternatives

## Pitch

## Additional context

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.