dmlc / dmlc/cub

digits "specified from least significant to most significant"

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Cuda
Stars
24
Forks
12
PR merge metrics
No merged PRs in 30d

Description

https://github.com/dmlc/cub/blob/05eb57faa0a4cac37c2a86fdf4b4dc865a95a1a3/cub/device/device_radix_sort.cuh#L59

I am having a hard time interpreting the documentation where it says the keys may be an ordered sequence of characters, digits etc., "specified from least significant to most significant". This phrase occurs in >1 place I think.

The issue is that the examples only seem to let the key value be a builtin type like int, float, double and so on. Those types do have less and more significant bits, but it would not be meaningful to say that we specify the digits "from least significant to most significant" unless we were making a statement about the system endian-ness. I can only see that this would be meaningful if the templated type were allowed to be, say, "int32_t[4]", and if that's the case it would be nice for it to be clarified.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.