dmarx / dmarx/ComfyUI-Keyframed

pre-ship checklist

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
92
Forks
8
PR merge metrics
No merged PRs in 30d

Description

# Features
- [x] node which facilitates combining and normalizing lots of conds/curves for the user
- [x] combine manny
- ~~[ ] combine many and normalize~~
- [x] arithmetic reductions (sum, prod) that take more than 2 inputs
- [x] ensure we have a satisfactory install sequence.
- i think right now the dependencies are just in `requirements.txt`. check other nodes for best practice install sequence

- [x] drawing functionality for schedules

- [x] node to collect several curves into a single pgroup
- [x] pgroup vs curve arithmetic
- [ ] pgroup reductions (broken upstream?)
- [x] sum over pgroup
- [x] prod over pgroup

# Bugs
- [x] cond addition is not order invariant and changing order can result in undercooked/deepfried animations
- [x] sprinkle `deepcopy` around `core.py` nodes
- [x] interpolators not working on schedule
- [ ] exp_decay - missing parameter
- [x] sine_wave - throws error on a division operation

# documentation

- [ ] screenshots of new nodes in readme
- [ ] parameter group stuff
- [ ] drawing utilities
- [x] update workflow images for aliased names and new nodes
- [x] add demo for superposition with utility nodes
- [ ] link out from `keyframed` to `comyui-keyframed`
- [x] do a release of `keyframed` as well. low hanging fruit: add total_ordering to Keyframed class
- [ ] expand curve drawing demo
- [ ] add yaml-initialized fancy curve to drawing demo
- [ ] sinusoidal
- [x] superposition
- [x] different interpolators
- [ ] LFOs (once those are a thing)

# Scope Creep (move to next release

- [ ] LFOs
- [ ] combine many and normalize
- [ ] `1-x` operator

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.