dlt-hub / dlt-hub/dlt

chore: update typing from `List` to `list`

Open
#2,897 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech-debt
Dominant language
Python
Stars
5.9k
Forks
605
Avg merge
1d 14h
Merged PRs (30d)
38

Description

Can use pyupgrade ([this rule](https://github.com/asottile/pyupgrade?tab=readme-ov-file#pep-585-typing-rewrites)) to ensure all the necessary changes are made automatically. We should enable rules 1-by-1 in different PR/commits to facilitate reviews (a lot of lines are expected to change).

We can add the commit to `.git-blame-ignore-revs` to keep a clean git history ([explanations](https://medium.com/@ramunarasinga/git-blame-ignore-revs-to-ignore-bulk-formatting-changes-f20ac23e6155))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the pyupgrade PEP 585 typing rewrites rule and inspect the repository for uses of typing.List and related annotations. Apply the rules one at a time so each change can be reviewed, then record the bulk-change commit in .git-blame-ignore-revs; done means the necessary typing updates are complete and the commits remain reviewable.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.