django / django/code.djangoproject.com

PR status only take the first check into account

Open
#225 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
66
Forks
62
PR merge metrics
No merged PRs in 30d

Description

I was confused today because my PR was marked as "build: success" on Trac, but it had fail on github.

Investigating the issue, I discovered that the javascript that figures out the status of a PR only takes the first check into account: https://github.com/django/code.djangoproject.com/blob/a8774abd91108baa70eb936c5ad5a736dd646b5b/trac-env/htdocs/tickethacks.js#L124

Considering we have around 50 checks, I don't think this logic is accurate.

I would suggest that the status should be "building" if any individual check has status=building, "error" if at least one check has status=error, and "success" only if all checks have status=success (not sure if there are other statues to take into account)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.