django-simple-deploy / django-simple-deploy/dsd-flyio

Clean up e2e test for linux

Open
#8 1 comment 0 reactions 0 assignees View on GitHub
testing
Dominant language
Python
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

On Linux, need to use shell=True, and whole commands instead of parts. There are a bunch of conditional tests for Linux, that can be simplified.

- [ ] Update make_sp_call() in core e2e test utils to accept use_parts arg.
- [ ] Simplify existing checks about Windows, heroku, etc. make_sp_call() should not do any of that inspection.
- [ ] Simplify calls in e2e test utils for this plugin with the updated core test utility function.
- [ ] See also [core issue 405](https://github.com/django-simple-deploy/django-simple-deploy/issues/405), about removing use of `shell=True`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with make_sp_call() in the core e2e test utilities, then inspect the plugin's e2e test utility calls that use it. Review core issue 405 for the shell=True context, update the utility and simplify the Linux, Windows, and Heroku checks described in the checklist. Run the e2e tests to confirm the revised command handling works.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud, devops, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.