django-haystack / django-haystack/django-haystack
should_update is not honored by rebuild_index management command
Open
Nobody has claimed this yet.
needs review
- Dominant language
- Python
- Stars
- 3.7k
- Forks
- 1.3k
- Avg merge
- 3h 18m
- Merged PRs (30d)
- 3
Description
should_update is not called during the rebuilding of index. This is because the backend's update method is called directly. Perhaps a fix would be to move the call to should_update inside backend's update
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the rebuild_index management command and trace its direct call to the backend update method, then inspect how should_update is handled. Done means should_update is invoked during index rebuilding while existing update behavior remains correct; verify this with the relevant tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- backend, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100