django-haystack / django-haystack/django-haystack
routers `for_write()` now receives 'models' as part of the hints
Open
Nobody has claimed this yet.
needs review
- Dominant language
- Python
- Stars
- 3.7k
- Forks
- 1.3k
- Avg merge
- 3h 18m
- Merged PRs (30d)
- 3
Description
The for_write() in the routers only received the index. Now it receives 'models' too:
https://github.com/Kronuz/django-haystack/commit/af164d3b5619674f75277ce3de4fe6cafda640da
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the router implementations of for_write() and the linked commit to understand the changed hints contract. Trace its callers and existing checks to identify implementations that still accept only index. Done means the affected routers match the new contract and relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, backend-api-design
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100