django-haystack / django-haystack/celery-haystack

Problem with custom haystack router after upgrading to 0.9

Open
#46 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
226
Forks
95
PR merge metrics
No merged PRs in 30d

Description

I use a custom haystack router that inherits from haystack.DefaultRouter and overrides for_read and for_write methods. After upgrading from 0.8 to 0.9 it suddenly stopped working, the for_read method is never called, however the router class is instantiated (__init__ is called).

If I downgrade to 0.8 it works fine.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the custom haystack.DefaultRouter behavior on versions 0.8 and 0.9, focusing on the overridden for_read and for_write methods and confirming that init still runs while for_read does not. Trace the router dispatch path in the 0.9 integration and compare it with 0.8; done means the custom for_read method is invoked again under 0.9 and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.