divviup / divviup/janus

Enforce `unknown_verification_key_id`

Open
#4,787 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

https://github.com/ietf-wg-ppm/draft-ietf-ppm-dap/pull/784

If AggregationJobInitReq.verification_key_id doesn't identify a key configured for the task, the Helper MUST reject each report with unknown_verification_key_id; the Leader MAY retry with a different key ID.

Today the field is log-only (aggregator/src/aggregator.rs:2268) and AggregatorTask holds a single unkeyed vdaf_verify_key (aggregator_core/src/task.rs:143), so this needs a key-ID --> key mapping on the task.

Probably needs a coordinated divviup-api change.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DAP requirement in PR 784, then inspect aggregator/src/aggregator.rs:2268 and AggregatorTask in aggregator_core/src/task.rs:143. Trace how verification_key_id is currently logged and how divviup-api represents task configuration; done means configured key IDs are mapped to keys and an unknown ID causes the Helper to reject each report with unknown_verification_key_id.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.