divviup / divviup/janus

Compact and renumber `ReportError`

Open
#4,786 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

github.com/ietf-wg-ppm/draft-ietf-ppm-dap/pull/786

Janus (~messages/src/lib.rs:2465) has task_expired(7), invalid_message(8), report_too_early(9), task_not_started(10);

draft-19 is invalid_message(7), report_too_early(8), unknown_verification_key_id(9), unsupported_extension(10).

So -- task_expired and task_not_started are gone, folded into report_dropped(3).

Audit these, fix it up.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at messages/src/lib.rs:2465 and compare the ReportError definitions and uses with the draft-19 numbering described in the issue. Audit references to task_expired and task_not_started, folding them into report_dropped as specified, and verify that the remaining errors use the draft-19 numbers. Done means the implementation matches the listed draft-19 ReportError values throughout.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.