divviup / divviup/janus

Prevent self-DoS by collector

Open
#425 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
70
Forks
16
Avg merge
4h 36m
Merged PRs (30d)
30

Description

We should prevent collectors from accidentally performing a successful collection with an interval that spans too far in the future. (because this would block all new report uploads until that interval elapses) There are two ways we could handle this as the leader: either accept collect requests as we do now, and delay collection until the collect interval has passed (plus some grace period), or immediately reject collect requests that span too far in the future with an error. As helper, our options are more limited, and all we can do is return an error in response to aggregate share requests or not.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing leader collect requests and helper aggregate share requests, then determine how future-spanning intervals are validated and which behavior should be chosen; done requires preventing the collection block through a defined rejection or delayed-collection policy.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems, security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.